Declare test task inputs. #1304
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gradle build cache is disabled for this project, but if it were enabled, the integration tests would be cached even when files and properties they depend on would be used.
oehme
reviewed
Apr 17, 2019
| @@ -46,6 +46,11 @@ dependencies { | |||
| } | |||
|
|
|||
| test { | |||
| inputs.files("../gradle/dependencies.gradle").withPathSensitivity(PathSensitivity.RELATIVE) | |||
There was a problem hiding this comment.
Relative path sensitivity only makes sense for directories. What you want here is NONE, because you don't care about the path at all, only the contents.
oehme
reviewed
Apr 17, 2019
| @@ -46,6 +46,11 @@ dependencies { | |||
| } | |||
|
|
|||
| test { | |||
| inputs.files("../gradle/dependencies.gradle").withPathSensitivity(PathSensitivity.RELATIVE) | |||
| inputs.property("ANDROID_HOME", System.getenv("ANDROID_HOME")) | |||
There was a problem hiding this comment.
This will prevent cache relocation, as you are using an absolute path. I'm sure you don't care about the path at all, but about what's installed there. So it's best to declare the actual files you care about in there as input files.
oehme
reviewed
Apr 17, 2019
| inputs.files("../gradle/dependencies.gradle").withPathSensitivity(PathSensitivity.RELATIVE) | ||
| inputs.property("ANDROID_HOME", System.getenv("ANDROID_HOME")) | ||
| inputs.property("TRAVIS_OS_NAME", System.getenv("TRAVIS_OS_NAME")) | ||
| inputs.dir("../gradle/wrapper").withPathSensitivity(PathSensitivity.RELATIVE) |
There was a problem hiding this comment.
Why are you using the wrapper as an input? Use TestKit to test plugins instead.
There was a problem hiding this comment.
We are using it in this project
|
gonna close this out since its red and inactive, feel free to reopen if we'd like to revisit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gradle build cache is disabled for this project, but if it were enabled,
the integration tests would be cached even when files and properties
they depend on would be used.
See: gradle/gradle#9151 for more info.