Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only download IntelliJ if no local copy exists #2167

Merged
merged 1 commit into from Feb 21, 2021

Conversation

3flex
Copy link
Contributor

@3flex 3flex commented Feb 17, 2021

When working with the SQLDelight project I seemed to end up with IntelliJ downloading every time Gradle ran its configuration phase which is a bit wasteful.

The overwrite flag does what you'd expect, while tempAndMove:

true if the file should be downloaded to a temporary location and, upon successful execution, moved to the final location. If overwrite is set to false, this flag is useful to avoid partially downloaded files if Gradle is forcefully closed or the system crashes.

Copy link
Member

@JakeWharton JakeWharton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alec?

@3flex
Copy link
Contributor Author

3flex commented Feb 21, 2021

The copy task is always run during configuration as well, unzipping even when the downloaded ZIP hasn't changed. It could be could be enclosed in doLast so the copy is done during execution phase instead of configuration phase. That also saves 10s of seconds on my (old) laptop every time Gradle's configuration phase runs.

@AlecKazakova
Copy link
Collaborator

yea looks good to me, try rebasing to pass ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants