Add import quick fix for unknown type

[aperfilyev]

Screen.Recording.2021-04-08.at.17.20.43.mov

How do I unit test this?

closes #683

[AlecKazakova]

YOOOOOOOOOOOOOOOOOOO NICE

[AlecKazakova]

i think you can unit test this similar to how we do the expand intention:

https://github.com/cashapp/sqldelight/blob/master/sqldelight-idea-plugin/src/test/kotlin/com/squareup/sqldelight/intellij/intentions/ExpandColumnNamesWildcardQuickFixTest.kt#L49-L50

however if that is proving really difficult im okay merging as is

[aperfilyev]

i think you can unit test this similar to how we do the expand intention:

I've tried but it doesn't resolve nor intentions nor quick fixes

[veyndan]

This looks awesome!!!

[aperfilyev]

It seems there are compatibility problems with an older IC-193.7288.26, what should I do?

[AlecKazakova]

I think we can probably drop that version, I believe android studio stable is on 2020 now. I will double check before merging

…

On Thu, Apr 8, 2021 at 5:10 PM Alexander Perfilyev ***@***.***> wrote: It seems there are compatibility problems with an older IC-193.7288.26, what should I do? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2260 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMZBQHK2T6MN3KW2WYKDZTTHYLSPANCNFSM42TSH37A> .

[aperfilyev]

Yep, 4.1 is indeed on 2020.1 https://developer.android.com/studio/releases#4.1-intellij-idea

[AlecKazakova]

boom, thanks

[ursusursus]

If I may report, it doesn't seem to work for nested classes

data class DocumentId(val value: String)

data class Document(
    val id: DocumentId,
    val type: Type,
) {
    enum class Type {
        CONTRACT, FIN_DOC, WARRANTY_CLAIM, OTHER
    }
}

CREATE TABLE IF NOT EXISTS document (
    id TEXT AS DocumentId NOT NULL, <-- alt enter shows import
    type TEXT AS Document.Type NOT NULL, <-- alt enter here does nothing

    PRIMARY KEY (id, subscriberId)
);

[ursusursus]

Also, List seems to not include kotlin.collections.List

[ursusursus]

Also, when nested type is used, the parent is grayed out as not use, which is not true

[ursusursus]

Disambiguation is not right

Only sk.o2.product.Tariff, sk.tm.mobile.subscriber.Tariff should be visible; others are from modules which are not included, it seems that the list of options is just plain search for "Tariff" everywhere

[JakeWharton]

Please file new issues if you have reproducible problems with this functionality.