-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify using schema migrations for JdbcSqliteDriver #3737
Conversation
The JDBC driver probably isn't the place for this since Maybe this would be better off as a separate module in |
@dellisd thank you for your response, it is extensions on JdbcSqliteDriver only, so this is for JDBC's Sqlite specialized implementation only. Other Sqlite drivers (native, JS) has their own way for migrations inbuilt too. See |
Ah I didn't realize the native driver supported this already, thanks. I don't think the JS driver does though, other than creating the schema without any checks (actually that sounds like a bug). But I see what you mean. It could be better to build this into the SQLite drivers (JVM/JS) since it's already supported on half of the platforms we target. |
Yes, do you need anything from me in this? I don't know now what to do actually :) |
...sqlite-driver/src/main/kotlin/app/cash/sqldelight/driver/jdbc/sqlite/JdbcSqliteMigrations.kt
Outdated
Show resolved
Hide resolved
...sqlite-driver/src/main/kotlin/app/cash/sqldelight/driver/jdbc/sqlite/JdbcSqliteMigrations.kt
Outdated
Show resolved
Hide resolved
...sqlite-driver/src/main/kotlin/app/cash/sqldelight/driver/jdbc/sqlite/JdbcSqliteMigrations.kt
Outdated
Show resolved
Hide resolved
…d update user documentation
@AlecStrong I updated to latest changes and applied your suggestion and updated documentation. Only thing I struggle with is test, can you please help? |
@morki What do you mean with test? Do you need help adding a test or do you mean the failing CI due using star imports? I fixed the latter to enable merging. |
@hfhbd I thought adding unit test, if you think it is required. |
See #2355, if this can be accepted, I will update documentation in this PR too.