Rename named argument and parameter usage on column rename #4027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aperfilyev
force-pushed
the
aperfilyev/rename-named-arg
branch
from
750e70f
to
6ef2c42
Compare
|
Should this also generate a new migration file that creates a new temporary table, fills the data, deletes the 'old' table and renames the temporary table? We do have this mechanism already somewhere. I think when removing a column from a table. |
yep and the code for this is in place but it doesn't seem to work, maybe a bug |
aperfilyev
force-pushed
the
aperfilyev/rename-named-arg
branch
from
6ef2c42
to
7e7337f
Compare
aperfilyev
force-pushed
the
aperfilyev/rename-named-arg
branch
from
7e7337f
to
f7291c1
Compare
AlecKazakova
approved these changes
Apr 11, 2023
AlecKazakova
pushed a commit
that referenced
this pull request
Apr 12, 2023
This reverts commit 1c00bff.
AlecKazakova
pushed a commit
that referenced
this pull request
Apr 12, 2023
aperfilyev
added a commit
to aperfilyev/sqldelight
that referenced
this pull request
Apr 20, 2023
…#4027)" (cashapp#4051)" This reverts commit d19e01c.
aperfilyev
added a commit
to aperfilyev/sqldelight
that referenced
this pull request
Apr 20, 2023
…#4027)" (cashapp#4051)" This reverts commit d19e01c.
AlecKazakova
pushed a commit
that referenced
this pull request
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screencast.from.30.03.2023.21.13.33.webm
and find usages
Screencast from 30.03.2023 21:14:53.webm
closes #2077