Warn about missing WHERE inside DELETE or UPDATE #4058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanniktech
reviewed
Apr 13, 2023
|
|
||
| DELETE FROM example WHERE id = 1; | ||
|
|
||
| DELETE FROM example; |
There was a problem hiding this comment.
Not sure how I feel about this being linted. I have this for almost every table to prune it.
There was a problem hiding this comment.
same for me, I think in general its a reasonable type of query to run
There was a problem hiding this comment.
if theres a way to have it default off i think id b cool with that
There was a problem hiding this comment.
This is similar to https://www.jetbrains.com/help/phpstorm/sql-delete-or-update-statement-without-where-clauses.html and it's enabled by default
Anyway, I'm going to turn it off
|
|
AlecKazakova
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.