Use stable output path for generated source #4269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hfhbd
approved these changes
Jun 12, 2023
hfhbd
reviewed
Jun 12, 2023
| } else { | ||
| generatedSourcesDirectory | ||
| } | ||
| private val Source.outputDir get() = File(generatedSourcesDirectory, name) |
There was a problem hiding this comment.
I have no idea why we did this and I already changed this in another locally branch too.
dellisd
approved these changes
Jun 12, 2023
|
@joshfriend Please fix the merge conflicts to run the CI. |
joshfriend
force-pushed
the
jf/single-variant-android
branch
from
9a0ae25
to
8c9abb4
Compare
|
This change would be nice to have backported to 1.x if possible, let me know if i can help with that somehow. |
|
The 1.x branch is the |
|
@dellisd Are you sure we still want to publish another 1.5.x release? |
|
(i have noticed the other test failures and am fixing them) |
Always include the variant name as part of output path Closes cashapp#4267
joshfriend
force-pushed
the
jf/single-variant-android
branch
from
8c9abb4
to
cee2113
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always include the variant name as part of output path
Closes #4267