Use Long as migration version

[hfhbd]

Fixes #4296

Draft because it needs a new sql-psi release (or use snapshot version)

[dellisd]

Won't this require a (breaking) runtime change too?

[hfhbd]

This isn’t part of the runtime, but part of the compiler which isn’t stable.

[dellisd]

Right, but SqlSchema.version is derived from this, isn't it? And also the values used for SqlSchema.migrate().

sqldelight/sqldelight-compiler/src/main/kotlin/app/cash/sqldelight/core/compiler/DatabaseGenerator.kt

Line 240 in 16526c3

maxVersion = maxOf(maxVersion, migrationFile.version + 1)

[hfhbd]

Ah, you mean behavior, I thought about api only.
Yes, this will change the current behavior, but the current behavior is undefined. If we find a numerical value in the name, we try to parse this value to Int. If this fails, we use 0 as fallback as migration version, which will be overridden in an non deterministic way by another migration version with 0 too.

[AlecKazakova]

generated code breakages are okay, since you cant have a published library that depends on that API

[hfhbd]

Will rebase once a new sql-psi release is out.

[vanniktech]

Should we also change it upstream in sqliter to be a Long? https://github.com/touchlab/SQLiter/blob/a5a532b012cd84d706d143938660094b87b2dfcc/sqliter-driver/src/nativeCommonMain/kotlin/co/touchlab/sqliter/DatabaseConfiguration.kt

On Android you'd be able to use Long but on native it would just crash:

sqldelight/drivers/native-driver/src/nativeMain/kotlin/app/cash/sqldelight/driver/native/NativeSqlDatabase.kt

Line 259 in da0d457

version = if (schema.version > Int.MAX_VALUE) error("Schema version is larger than Int.MAX_VALUE: ${schema.version}.") else schema.version.toInt(),

[hfhbd]

What do you mean with Android? The android driver does not support Long too and it also crashes.

[vanniktech]

So we only changed it for non android/ios consumers?

[hfhbd]

The change affects all targets, but from my view I would use a long version, eg version based on a timestamp, for backend systems. On mobile, you could easily use the build/release number as migration number, which is rarely bigger than Int.max.

Also, to get a crash, you need to change your versioning after using sqldelight 2.0.0-rc02. The old behaviour is still working.