Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle process cancellation during find usages #4340

Merged

Conversation

AlecKazakova
Copy link
Collaborator

Closes #4089

Copy link
Collaborator

@hfhbd hfhbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test?

@AlecKazakova
Copy link
Collaborator Author

we probably should but testing the intellij plugin is contrived for these types of scenarios (you would make this happen by clicking the 'x' during a find usages before its called this constructor) and so unless its a dead simple test I can write the intellij plugin crash fixes never get tests

@AlecKazakova AlecKazakova force-pushed the astrong/2023-07-06/process-canceled-find-usages branch from 08bca18 to 71d38e9 Compare July 6, 2023 16:21
@AlecKazakova AlecKazakova merged commit dd9be0e into master Jul 12, 2023
5 checks passed
@AlecKazakova AlecKazakova deleted the astrong/2023-07-06/process-canceled-find-usages branch July 12, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

java.lang.reflect.InvocationTargetException in ReflectiveKotlinFindUsagesFactory.kt:53
2 participants