Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 4501 PostgreSql sequence #4528

Merged
merged 11 commits into from
Nov 30, 2023

Conversation

griffio
Copy link
Contributor

@griffio griffio commented Aug 14, 2023

🍏 CREATE SEQUENCE ...

Currently, I am hooking into extension_stmt as this allows new CREATE statements to be defined ...
unless stmt can be overridden ... πŸ˜΅β€πŸ’«

  • Similar mix-in to CopyMixin for owner tableName column available
  • More tests
  • support calling functions currval, nextval, lastval, setval
  • ALTER/DROP can be another issue 🎟️

fixes #4501

@griffio griffio marked this pull request as ready for review August 15, 2023 11:57
@griffio griffio force-pushed the fix-4501-postgresql-sequence branch from 7d8fc9c to b6a3c34 Compare August 16, 2023 09:37
@griffio griffio changed the title Fix 4501 postgresql sequence Fix 4501 PostgreSql sequence Aug 26, 2023
@griffio griffio force-pushed the fix-4501-postgresql-sequence branch 2 times, most recently from cb2ea98 to 7d4b0f4 Compare August 29, 2023 11:50
@griffio griffio force-pushed the fix-4501-postgresql-sequence branch from 9fbc84b to 71e4e61 Compare October 2, 2023 11:31
@griffio griffio force-pushed the fix-4501-postgresql-sequence branch from 71e4e61 to 1147f6e Compare October 8, 2023 17:13
@AlecKazakova AlecKazakova merged commit 136849f into cashapp:master Nov 30, 2023
7 checks passed
@griffio griffio deleted the fix-4501-postgresql-sequence branch November 30, 2023 16:52
hfhbd pushed a commit that referenced this pull request Apr 2, 2024
* create sequence grammer

* test create sequence grammer

* add mixin to validate owner table

* add fixture tests with variants

* fix spotless

* add currval, nextval, lastval and setval

* add integration tests

* add function setval

add test

* Update PostgreSqlTest.kt

fix spotless whitespace

---------

Co-authored-by: griffio <griffio@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PostgreSQL no support for CREATE SEQUENCE
3 participants