Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 3916 PostgreSql rename column #4566

Merged

Conversation

griffio
Copy link
Contributor

@griffio griffio commented Aug 25, 2023

馃尩 SqlColumnAlias element doesn't implement SqlColumnName but is added to table columns for querying later.
After the columns were modified during a rename the element was not found on subsequent query of SqlColumnName types.

Now, implementing as SqlColumnName it takes the first child element of the pair of SqlColumnName types representing the a to b rename.

fixes #3916

SqlColumnAlias doesn't implement SqlColumnName
After the columns are modified during a rename the element is not found on subsequent query of SqlColumnName
Check the columns are renamed
@griffio griffio changed the title fix 3916 PostgreSql rename column Fix 3916 PostgreSql rename column Aug 25, 2023
@AlecKazakova AlecKazakova merged commit 05fb10e into cashapp:master Aug 28, 2023
7 checks passed
@griffio griffio deleted the fix-3916-postgresql-rename-column branch December 4, 2023 14:13
hfhbd pushed a commit that referenced this pull request Apr 2, 2024
* fix 3916 PostgreSql rename column

SqlColumnAlias doesn't implement SqlColumnName
After the columns are modified during a rename the element is not found on subsequent query of SqlColumnName

* Add more fixture tests

Check the columns are renamed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postgres can't rename column multiple times
2 participants