Add Language annotations for more pleasant SQL editing #4602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the execute and executeQuery methods isn't how SQLDelight is meant to be used, but they are an important escape hatch or when the compiler/dialect hasn't yet implemented a needed feature. Marking the parameters as SQL makes for a better editing experience in Intellij. The required annotations are already on the classpath for these drivers.
|
I think this is something that would be better to implement through the IntelliJ plugin so that it could be applied to all driver implementations, not just the JDBC/R2DBC ones. |
|
I think, we should do both to use the feature/annotation without the sqldelight plugin too. |
AlecKazakova
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the execute and executeQuery methods isn't how SQLDelight is meant to be used, but they are an important escape hatch or when the compiler/dialect hasn't yet implemented a needed feature. Marking the parameters as SQL makes for a better editing experience in Intellij.
The required annotations are already on the classpath for these drivers.