Fix JdbcSqliteDriver url parsing when choosing ConnectionManager type
#4656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellisd
reviewed
Sep 23, 2023
...ers/sqlite-driver/src/main/kotlin/app/cash/sqldelight/driver/jdbc/sqlite/JdbcSqliteDriver.kt
Outdated
Show resolved
Hide resolved
05nelsonm
force-pushed
the
issue/4018-jdbc-sqlite-conn-manager
branch
from
69a6919
to
8c0a6f4
Compare
Added |
05nelsonm
commented
Sep 25, 2023
...ers/sqlite-driver/src/main/kotlin/app/cash/sqldelight/driver/jdbc/sqlite/JdbcSqliteDriver.kt
Outdated
Show resolved
Hide resolved
dellisd
approved these changes
Sep 25, 2023
|
Thank you for making this fix! |
hfhbd
pushed a commit
that referenced
this pull request
Apr 2, 2024
…type (#4656) * Fix url parsing behavior when choosing connection manager * Modify class name to be more descriptive of ConnectionManager type * Add ephemeral unit tests * Add link to sqlite.org documentation * Fix documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4018
This PR fixes a an issue when choosing which type of
ConnectionManagershould be utilized, depending on what parameters are passed via url where a static connection is needed to be maintained.