Add PostgreSql temporal types to SqlBinaryExpr #4657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
griffio
changed the title
griffio
force-pushed
the
add-postgresql-temporal-types
branch
from
f79f1b6
to
6b77da1
Compare
griffio
force-pushed
the
add-postgresql-temporal-types
branch
from
0736643
to
ba80c52
Compare
griffio
force-pushed
the
add-postgresql-temporal-types
branch
from
ba80c52
to
71dff65
Compare
griffio
force-pushed
the
add-postgresql-temporal-types
branch
from
71dff65
to
150e143
Compare
For encapsulatingType allow expressions to return temporal types
PostgreSqlType.INTERVAL,
PostgreSqlType.TIMESTAMP_TIMEZONE
PostgreSqlType.TIMESTAMP
e.g 31 * INTERVAL '1 minute' + INTERVAL '2 days'
Timestamp should be ordered last
When binary expression contains TIMESTAMP and INTERVAL, TIMESTAMP must be selected
Extend the existing tests with binary expressions
griffio
force-pushed
the
add-postgresql-temporal-types
branch
from
150e143
to
764338d
Compare
hfhbd
reviewed
Nov 16, 2023
| @@ -252,12 +252,31 @@ class PostgreSqlTest { | |||
| assertThat(now).isGreaterThan(OffsetDateTime.MIN) | |||
| } | |||
|
|
|||
| @Test fun nowPlusInterval() { | |||
There was a problem hiding this comment.
Minor, you could also use SELECT NOW(), NOW() + INTERVAL '1 day' and compare the two values in Java/Kotlin.
There was a problem hiding this comment.
Ok - have compared now plus 1 > now
hfhbd
reviewed
Nov 16, 2023
| @Test fun interval() { | ||
| val interval = database.datesQueries.selectInterval().executeAsOne() | ||
| assertThat(interval).isNotNull() | ||
| assertThat(interval.getDays()).isEqualTo(1) | ||
| } | ||
|
|
||
| @Test fun intervalBinaryMultiplyExpression() { |
hfhbd
approved these changes
Nov 16, 2023
Check that now + 1 is greater than now
hfhbd
pushed a commit
that referenced
this pull request
Apr 2, 2024
* Update PostgreSqlTypeResolver temporal type
For encapsulatingType allow expressions to return temporal types
PostgreSqlType.INTERVAL,
PostgreSqlType.TIMESTAMP_TIMEZONE
PostgreSqlType.TIMESTAMP
e.g 31 * INTERVAL '1 minute' + INTERVAL '2 days'
Timestamp should be ordered last
When binary expression contains TIMESTAMP and INTERVAL, TIMESTAMP must be selected
* Add PostgreSql integration tests
Extend the existing tests with binary expressions
* Change test to compare two intervals
Check that now + 1 is greater than now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some missing support for binary expressions with temporal types:
TIMESTAMP is added last to the type-order as it needs to be the result of a binary expression containing a TIMESTAMP and INTERVAL
Examples