Update From false positive for multiple columns found with name

[eygraber]

No description provided.

[griffio]

🔢 There are a few of these 'Multiple columns found with name...' issues #4767 (comment)
Maybe create this as an issue 🎫 as well

I was looking into these - but is quite complex 😵‍💫

In the PR above - it would seem that the sub query in the FROM is not flagged as adjacent to the UPDATE.

e.g UpdateStmtLimitedMixin - I think you can make the test pass by amending to return super.queryAvailable(child).map { it.copy(adjacent = true) } + joinClause!!.queryExposed()

sqldelight/dialects/sqlite-3-33/src/main/kotlin/app/cash/sqldelight/dialects/sqlite_3_33/grammar/mixins/UpdateStmtLimitedMixin.kt

Line 18 in 2e76f94

return super.queryAvailable(child) + joinClause!!.queryExposed()

Other source of error message is in sql-psi
https://github.com/AlecKazakova/sql-psi/blob/114fb05320f48b45c57583d41b3792567a9a0d34/core/src/main/kotlin/com/alecstrong/sql/psi/core/psi/SqlColumnReference.kt#L61

[eygraber]

@griffio thanks for the pointer. Marking the results from super.queryAvailable would technically work, but I don't think those are adjacent in this case. Marking the joinClause!!.queryExposed() results as adjacent also works, and I think is more correct. Updating the PR now.

[hfhbd]

Yes, using the joinClause is better.