Add a windowSizeBytes parameter to AndroidSqliteDriver #4804
+41
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
approved these changes
Nov 13, 2023
| windowSizeBytes != null && | ||
| cursor is AbstractWindowedCursor | ||
| ) { | ||
| cursor.window = CursorWindow(null, windowSizeBytes) |
There was a problem hiding this comment.
Can you move this line into another class so that its code verification is deferred unless needed.
You can read about why here: https://github.com/androidx/androidx/blob/androidx-main/docs/api_guidelines/compat.md#checking-device-sdk-version-compat-sdk
hfhbd
pushed a commit
that referenced
this pull request
Apr 2, 2024
* Add a windowSizeBytes parameter to AndroidSqliteDriver * Move API 28 call to dedicated class, per https://github.com/androidx/androidx/blob/androidx-main/docs/api_guidelines/compat.md#checking-device-sdk-version-compat-sdk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android has the concept of a cursor window, where a query will try to preemptively load data up to a certain size (by default 2MB). However if individual rows are too big to fit that size, a
SQLiteBlobTooBigExceptionwill be thrown.A few issues where this happens:
More context about CursorWindow in this blog post.
Since Android 28+ this can be mitigated by controlling the window size. This PR adds the ability to pass this value to AndroidSqliteDriver.