-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump intellij version #4983
Bump intellij version #4983
Conversation
eb75df5
to
ff7a1da
Compare
It seems like AlecKazakova/sql-psi#583 is required for tests to pass |
cashapp#4983 will take some time, so let's fix it separately
cashapp#4983 will take some time, so let's fix it separately
cashapp#4983 will take some time, so let's fix it separately
cashapp#4983 will take some time, so let's fix it separately
#4983 will take some time, so let's fix it separately
sqldelight-idea-plugin/build.gradle
Outdated
"IC-2023.2", // IC | ||
"IC-2023.1.5", // IC | ||
"IC-2023.2.5", // IC | ||
// "IC-2023.3.2", // IC TODO: requires fix in com.alecstrong.sql.psi.core.SqlCoreEnvironment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What fix is needed?
#4983 will take some time, so let's fix it separately
gonna push to this branch as i update sql-psi and some other intellij stuff |
also closes cashapp#4894 and cashapp#4741
489ae6d
to
fe45742
Compare
@@ -25,6 +25,7 @@ class MigrationParserDefinition : SqlParserDefinition() { | |||
|
|||
private val FILE = object : ILightStubFileElementType<PsiFileStub<SqlFileBase>>(MigrationLanguage) { | |||
override fun getStubVersion(): Int = this@Companion.stubVersion | |||
override fun getExternalId(): String = "SqlDelight.MIGRATION" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing, i was just trying to figure out what was throwing this error
fe45742
to
7064677
Compare
3b75936
to
0ac4656
Compare
889e16a
to
4c1756b
Compare
also closes #4894 and #4741