Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump intellij version #4983

Merged
merged 4 commits into from
Apr 5, 2024
Merged

Conversation

aperfilyev
Copy link
Collaborator

also closes #4894 and #4741

@aperfilyev aperfilyev force-pushed the aperfilyev/bump-idea branch 2 times, most recently from eb75df5 to ff7a1da Compare January 25, 2024 21:13
@aperfilyev
Copy link
Collaborator Author

It seems like AlecKazakova/sql-psi#583 is required for tests to pass

aperfilyev added a commit to aperfilyev/sqldelight that referenced this pull request Jan 27, 2024
cashapp#4983 will take some time, so let's fix it separately
aperfilyev added a commit to aperfilyev/sqldelight that referenced this pull request Jan 27, 2024
cashapp#4983 will take some time, so let's fix it separately
aperfilyev added a commit to aperfilyev/sqldelight that referenced this pull request Jan 28, 2024
cashapp#4983 will take some time, so let's fix it separately
aperfilyev added a commit to aperfilyev/sqldelight that referenced this pull request Jan 28, 2024
cashapp#4983 will take some time, so let's fix it separately
AlecKazakova pushed a commit that referenced this pull request Jan 29, 2024
#4983 will take some time, so let's fix it separately
"IC-2023.2", // IC
"IC-2023.1.5", // IC
"IC-2023.2.5", // IC
// "IC-2023.3.2", // IC TODO: requires fix in com.alecstrong.sql.psi.core.SqlCoreEnvironment
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What fix is needed?

hfhbd pushed a commit that referenced this pull request Apr 2, 2024
#4983 will take some time, so let's fix it separately
@AlecKazakova
Copy link
Collaborator

gonna push to this branch as i update sql-psi and some other intellij stuff

@@ -25,6 +25,7 @@ class MigrationParserDefinition : SqlParserDefinition() {

private val FILE = object : ILightStubFileElementType<PsiFileStub<SqlFileBase>>(MigrationLanguage) {
override fun getStubVersion(): Int = this@Companion.stubVersion
override fun getExternalId(): String = "SqlDelight.MIGRATION"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing, i was just trying to figure out what was throwing this error

@AlecKazakova AlecKazakova merged commit b372df0 into cashapp:master Apr 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BugSnag fails to init in IDEA 2023.3
3 participants