Add a SqlDriver for Androidx KMP SQLiteDriver #5283
Conversation
eygraber
force-pushed
the
androidx-sqlite-driver
branch
from
b7ca0b5
to
76bc146
Compare
|
Once I'm here, this line from AndroidSqliteDriver tripped me up. I can't figure out in what scenario the previous connection should be closed, because if |
drivers/kmp-driver/src/commonMain/kotlin/app/cash/sqldelight/driver/kmp/KmpSqliteSchema.kt
Outdated
Show resolved
Hide resolved
Two threads racing at the same time. |
Should've been my first guess 😅 cache4k doesn't have the same semantics as LruCache so to handle that you need to listen for an Update event, and if the values don't match each other, close the old one. |
eygraber
force-pushed
the
androidx-sqlite-driver
branch
2 times, most recently
from
68dff3e
to
2dda23e
Compare
|
Some weird stuff going on with tests that I'm working through. Also had an idea for how to make this work on native. Should I do that here, or have a follow up PR? |
eygraber
force-pushed
the
androidx-sqlite-driver
branch
2 times, most recently
from
14cf97a
to
131fab9
Compare
|
Got a native implementation in. I don't have the most experience with Native APIs, but I think this should clean up after itself since in I'm also good with removing that part for now. In any case this should be ready to go. |
eygraber
force-pushed
the
androidx-sqlite-driver
branch
6 times, most recently
from
5e697c2
to
b7669b4
Compare
eygraber
force-pushed
the
androidx-sqlite-driver
branch
from
b7669b4
to
7c89bfc
Compare
- The issue was this driver executes more than the Android one because of the PRAGMA version calls
- Solution was to increment the identifier so it doesn't clash with the previous one (using a cached query for a statement and vice versa
- There was also a Robolectric issue with unclosed Closeables
- I fixed that for the existing AndroidSqliteDriver tests as well
eygraber
force-pushed
the
androidx-sqlite-driver
branch
from
7c89bfc
to
8d6fe34
Compare
Currently blocked by cashapp/sqldelight#5283
Androidx has a
SQLiteDriverthat targets Android, iOS, Mac, Linux, and JVM Desktop.This PR provides a
SqlDriverthat wraps it. Currently the implementation only works for Android and JVM (it uses aThreadLocaland I wanted to get some feedback before expanding that functionality to the native targets).