GH releases do not have binaries attached

[MiSikora]

github-release is a separate job from the publish job. When binaries are collected by action-gh-release step they are not present in the directory.

turbine/.github/workflows/release.yaml

Lines 54 to 58 in 39740b4

	- name: Create release
	uses: softprops/action-gh-release@v1
	with:
	body: ${{ steps.release_notes.outputs.release_notes }}
	files: build/libs/*

https://github.com/cashapp/turbine/runs/1024853027?check_suite_focus=true#step:5:10

Since github-release job needs publish anyway they could be merged into a one job. This is just a suggestion as I don't know if there is a better way to do this.

On the side note, it would be nice to add binaries to already published GH releases retroactively.

[JakeWharton]

Since github-release job needs publish anyway they could be merged into a one job.

For nonsensical reasons the ffurrer2/extract-release-notes step only runs on Linux.

Because we need to build binaries on multiple platforms we would have to cache those artifacts from the Mac and Windows workers and then upload them from Linux. I'd take a PR to do this. Unfortunately it's going to be relatively low priority for me to fix.

The artifacts are all available here if you need them for now: https://repo1.maven.org/maven2/app/cash/turbine/

[MiSikora]

For nonsensical reasons the ffurrer2/extract-release-notes step only runs on Linux.

Ahh, got it. That's a bummer.

I think I'll make a contribution to the step instead of making a workaround here. I guess this issue can be kept open until fix lands in the step or someone takes care of caching.

[MiSikora]

Latest release v1.4.0-rc1 supports different platforms. I can make a PR with the change. Do you want to publish all binaries contained in the build/libs/* or do you want to exclude i.e. sources jar?

[JakeWharton]

We don't pay for the hosting, so might as well just do everything.

…

On Tue, Oct 27, 2020, at 1:09 PM, Michał Sikora wrote: Latest release `v.1.4.0-rc1` <https://github.com/ffurrer2/extract-release-notes/releases/tag/v1.4.0-rc.1> supports different platforms. I can make a PR with the change. Do you want to publish all binaries contained in the `build/libs/*` or do you want to exclude i.e. sources jar? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#14 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAQIEJPRDBZHFFNESP7SZTSM35D5ANCNFSM4S2YU2RA>.

[JakeWharton]

Closing this since I don't think it's high priority or essential.

[MiSikora]

Yeah, sorry for the radio silence. I attempted to do it but failed horribly at extracting native binaries in some sane way.

[JakeWharton]

Yeah I know it's a lot harder, and I'm not sure it's actually useful for someone to use.