Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use target mode as task dependency discriminator #587

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

yissachar
Copy link
Collaborator

Checks the Kotlin executable target mode against the webpack target mode, and only adds the Zipline compile task as a task dependancy if they both match. This prevents the issue where running development webpack causes both compile Zipline production and compile Kotlin production to run.

This approach is slightly fragile as it depends on both modes having the same name, but that's pretty unlikely to change.

@swankjesse
Copy link
Collaborator

NICE

@yissachar yissachar merged commit 2425fb0 into trunk Jul 25, 2022
@yissachar yissachar deleted the yissachar/use-target-mode-as-discriminator branch July 25, 2022 18:30
@yissachar yissachar restored the yissachar/use-target-mode-as-discriminator branch July 26, 2022 16:26
@yissachar yissachar deleted the yissachar/use-target-mode-as-discriminator branch July 26, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants