Fixup bitrots in the emoji search sample #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swankjesse
commented
Aug 15, 2022
| kotlin("plugin.serialization") | ||
| } | ||
|
|
||
| kotlin { | ||
| jvm() | ||
| android { |
There was a problem hiding this comment.
switching from JVM to Android as we now need an Android context to create a ZiplineLoader on any Android platform. This is because we use Android’s sqlite in the cache!
JakeWharton
approved these changes
Aug 15, 2022
swankjesse
commented
Aug 15, 2022
| @@ -19,7 +19,7 @@ import app.cash.zipline.ZiplineService | |||
| import kotlinx.coroutines.flow.Flow | |||
|
|
|||
| interface EmojiSearchPresenter : ZiplineService { | |||
| suspend fun produceModels( | |||
| fun produceModels( | |||
There was a problem hiding this comment.
This was unnecessary and it also triggered this bug: #654
Co-authored-by: Jake Wharton <jw@squareup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.