Replace env.HOSTNAME with dynamic hosts #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Egge21M
force-pushed
the
dynamic-hostname
branch
from
e0e5b8a
to
dd900c7
Compare
Egge21M
force-pushed
the
dynamic-hostname
branch
from
dd900c7
to
24416a6
Compare
Egge21M
force-pushed
the
dynamic-hostname
branch
from
24416a6
to
8ae7391
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the requirement for env.HOSTNAME and replaces it wherever required with the value of the
hostheader.Open questions: Should a
validDomainListbe implemented to reject connections from unknown hosts in order to prevent NIP98 replay attacks?