NUT-XX: WebSocket state updates #98
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 21, 2024
3 tasks
bumi
reviewed
Apr 1, 2024
XX.md
Outdated
| All requests sent from apps to mints over Websocket MUST look like this | ||
|
|
||
| ```json | ||
| ["REQ", "<REQ ID>", "<COMMAND>", "<PARAMS>"] |
There was a problem hiding this comment.
would it make sense to use the JSON-RPC format here?
There was a problem hiding this comment.
I don't have strong opinions about this. The format is already very close to the RPC spec so I wouldn't mind. What would be the benefit of adhering to it?
There was a problem hiding this comment.
What would be the benefit of adhering to it?
I'd guess mainly existing client libraries for using JSON-RPC rather than having to write your own
callebtc
changed the title
callebtc
added
needs implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my second take on an optional WebSocket protocol to allow bidirectional messages between clients and mints. WebSockets allow mints to push updates to clients without clients constantly polling them.
The proposal uses ids to keep track of requests, which removed the need to close and open sockets all the time and also allows for multiple request on a single socket connection.