ci: Do not cache locally published artifacts #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These workflows publish artifacts to local maven repository, which are then cached by GH Actions. Removing them at the end of the workflow prevents them to pollute the cache.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #316 +/- ##
=========================================
Coverage 91.20% 91.20%
Complexity 1211 1211
=========================================
Files 76 76
Lines 3151 3151
Branches 492 492
=========================================
Hits 2874 2874
Misses 164 164
Partials 113 113 ☔ View full report in Codecov by Sentry. |
|
@marcospereira it seems the windows build is still failing? |
This is good to go now. :-) |
|
Thank you @marcospereira! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
These workflows publish artifacts to the local maven repository, which are then cached by GH Actions. Removing them at the end of the workflow prevents them from polluting the cache.
Related to #310 (comment).
It would still be good to delete the existing caches before merging this, and check the effect it would have on #310. Deleting the caches is straightforward if you have GH CLI installed: