Use HTTPS to connect to sources that support it #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTTP sends plaintext messages, so it leaks information and is vulnerable to MITM attacks. ELPA, MELPA, and Marmalade all support HTTPS. We should make use of it. This changes the default addresses for those sources to use HTTPS. Users that have built Emacs to handle TLS will be able to make use of these sources, and Emacs will fall back to using regular HTTP if it isn't configured to handle TLS. This also updates the documentation to point to the HTTPS address of those repositories. This should close cask#323.
|
LGTM 👍. Thank you for making us aware, and for fixing the problem! 👏👍 |
|
@rejeep Shall we merge this? |
|
I haven'd had time to try it out yet. You make the call! 👍 |
|
I'll just merge then and look how it goes 😎 |
swsnr
added a commit
that referenced
this pull request
Nov 23, 2015
Use HTTPS to connect to sources that support it
|
💥 |
|
😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP sends plaintext messages, so it leaks information and is vulnerable to MITM attacks. ELPA, MELPA, and Marmalade all support HTTPS. We should make use of it.
This changes the default addresses for those sources to use HTTPS. Users that have built Emacs to handle TLS will be able to make use of these sources, and Emacs will fall back to using regular HTTP if it isn't configured to handle TLS.
This also updates the documentation to point to the HTTPS address of those repositories.
This should close #323.