Added BatchSourceContext.setInput(InputFormatProvider) #4512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chtyim
commented
Nov 9, 2015
chtyim
commented
- Remove usage of BatchContext.getHadoopJob
- Also move MapReduce classes under "mapreduce" package
chtyim
force-pushed
the
feature/etl-remove-hadoop-job-usage
branch
from
0b7277c
to
88f7f4c
Compare
chtyim
changed the title
chtyim
force-pushed
the
feature/etl-remove-hadoop-job-usage
branch
from
88f7f4c
to
2467d13
Compare
| config.put(entry.getKey(), entry.getValue()); | ||
| } | ||
| } catch (IOException e) { | ||
| // Shouldn't happen |
There was a problem hiding this comment.
Shouldn't happen because tpfsAvroConfig.schema has been validated before in configurePipeline method?
There was a problem hiding this comment.
The IOException is from the Job.getInstance() call.
|
One question. Rest LGTM 👍 |
| Configuration hConf = job.getConfiguration(); | ||
| hConf.clear(); |
There was a problem hiding this comment.
why is this needed? So the hConf passed to SourceInputFormatProvider on line 101 does not have anything other than DBConfiguration, ETLDBInputFormat properties?
There was a problem hiding this comment.
otherwise it'll have everything from the core-default.xml, which are unnecessary.
chtyim
force-pushed
the
feature/etl-remove-hadoop-job-usage
branch
from
9c2efc8
to
6a70f8d
Compare
|
Build passed: http://builds.cask.co/browse/CDAP-DUT3117-3 |
- Remove usage of BatchContext.getHadoopJob - Also move MapReduce classes under "mapreduce" package
chtyim
force-pushed
the
feature/etl-remove-hadoop-job-usage
branch
from
6a70f8d
to
d6f3a56
Compare
|
Squashed commits. Merging. |
chtyim
added a commit
that referenced
this pull request
Nov 10, 2015
…usage Added BatchSourceContext.setInput(InputFormatProvider)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.