Mark Workflow as FAILED if the action inside the workflow fails instead of marking it as COMPLETE. #7546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build is green here - http://builds.cask.co/browse/CDAP-DUT5245-17 |
prinam
requested review from
chtyim and
anwar6953
and removed request for
chtyim
anwar6953
reviewed
Feb 1, 2017
|
|
||
| @Override | ||
| public void completed() { | ||
| LOG.debug("Program {} completed successfully.", program.getId()); |
There was a problem hiding this comment.
can we log the runid also
anwar6953
reviewed
Feb 1, 2017
|
|
||
| @Override | ||
| public void killed() { | ||
| LOG.debug("Program {} killed.", program.getId()); |
There was a problem hiding this comment.
can we log the runid also
anwar6953
reviewed
Feb 1, 2017
| runtimeStore.setStart(program.getId(), runId.getId(), startTimeInSeconds, twillRunId, | ||
| options.getUserArguments().asMap(), options.getArguments().asMap()); | ||
|
|
||
| switch (state) { |
There was a problem hiding this comment.
actually no need to have KILLED state here, since when actions such as SUSPEND/KILLED would happen init listener would have executed at that time. This is similar to the https://github.com/caskdata/cdap/blob/develop/cdap-app-fabric/src/main/java/co/cask/cdap/internal/app/services/ProgramLifecycleService.java#L341
|
LGTM |
|
Build running here - https://builds.cask.co/browse/CDAP-DUT5389-1 |
sagarkapare
force-pushed
the
fix/cdap-6008
branch
from
78374c5
to
9e8edc4
Compare
|
Thank you @anwar6953 for the review. Build is green. Squashing and merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.cask.co/browse/CDAP-6008
Build: http://builds.cask.co/browse/CDAP-DUT5245-15
Fix contains -
WorkflowProgramRunnerProgramManagerinterface -waitForRun, andwaitForRunswhich are used in the unit tests instead ofwaitForFinishto make sure that the Workflow program is reached to the specified state.