CDAP-8036 add a fat coprocessor jar to hbase compat packages #7729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertshau
force-pushed
the
feature/CDAP-8036-coprocessor-packages
branch
2 times, most recently
from
86d39d7
to
da1a8e1
Compare
Added a fat jar containing all the CDAP coprocessors to every hbase compat package in a new 'coprocessor' directory. It is meant to be used in CDAP setups where the replication status tool is required, or setups where 'master.manage.hbase.coprocessors' is set to false in order to enable rolling hbase upgrades.
albertshau
force-pushed
the
feature/CDAP-8036-coprocessor-packages
branch
from
da1a8e1
to
fccd8e8
Compare
|
I tried running the command from cdap directory Seems like there are 2 issues -
|
|
hm good points. I tested this with an actual rpm, guess something in another profile sets package.name. As for the coprocessor directory in all other modules, was trying to avoid copying this logic in all compat poms, but may have to do that to fix it. |
The common profile was causing too many issues, so just moved the two additional executions into every compat module's dist profile. This will also make it so that existing builds don't need to change.
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a fat jar containing all the CDAP coprocessors to every
hbase compat package in a new 'coprocessor' directory. It is
meant to be used in CDAP setups where the replication status
tool is required, or setups where 'master.manage.hbase.coprocessors'
is set to false in order to enable rolling hbase upgrades.