Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CDAP-11781] Highlighting links in navbar + Beta flag removal in UI #9020

Merged
merged 1 commit into from
Jun 2, 2017

Conversation

ajainarayanan
Copy link
Contributor

@ajainarayanan ajainarayanan commented Jun 2, 2017

https://issues.cask.co/browse/CDAP-11788 - Remove Beta tag in Data Preparation
https://issues.cask.co/browse/CDAP-11784 - Fix highlighting Data Preparation & Overview when in appropriate views.
https://issues.cask.co/browse/CDAP-11789 - Fixes divider in dataprep menu
https://issues.cask.co/browse/CDAP-11790 - Fixes artifact upload wizard going underneath the drivers modal
Fixes js error creating and cloning pipeline for parsing macros.

nit:

  • Fixes the width of the cdap header image container so that the header links don't readjust after the image is loaded.

Copy link
Contributor

@elfenheart elfenheart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 code LGTM

@tonybach
Copy link
Contributor

tonybach commented Jun 2, 2017

New changes LGTM 👍

 - Fixes header highlighting in navbar for dataprep and overview pages
 - Removes references to BETA in dataprep
 - Fixes column actions dropdown divider to extend fully
 - Fixes zIndex for WizardModal to be 1061 to make it appear on top of the previously opened modals
 - Fixes default value for stages while creating or cloning a pipeline
 - Avoids refereshing one toggle when user browses through database while prepping data
@ajainarayanan ajainarayanan merged commit 01fdc04 into release/4.2 Jun 2, 2017
@ajainarayanan ajainarayanan deleted the bugfix_release/ui-CDAP-11781 branch June 2, 2017 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants