[CDAP-12849][CDAP-12869] Ops Dashboard Navigation #9979
Conversation
| import PropTypes from 'prop-types'; | ||
| import {getCurrentNamespace} from 'services/NamespaceStore'; | ||
|
|
||
| function NamespacesPickerView() { |
There was a problem hiding this comment.
nit: why not just export default function NamespacesPickerView()?
There was a problem hiding this comment.
there will be an expansion to this, it will be a connected component, it's just unfinished at the moment
| @@ -98,6 +106,36 @@ export function renderGraph(selector, containerWidth, containerHeight, data, leg | |||
| .select('line') | |||
| .remove(); | |||
|
|
|||
| let dateMap = {}; | |||
| data.forEach((d) => { | |||
| let time = parseInt(d.time); | |||
There was a problem hiding this comment.
nit: parseInt(d.time, 10)
|
|
||
| start = parseInt(start, 10); | ||
| duration = 1440; |
There was a problem hiding this comment.
nit: unnecessary, since you already set default duration = 1440 in the params?
elfenheart
changed the title
| .toggle-all-dropdown { | ||
| .dropdown-toggle-btn { | ||
| color: initial; | ||
| background-color: initial; |
There was a problem hiding this comment.
nit: I think @ajainarayanan once mentioned that we shouldn't use initial values anymore, since the browser default color might be different for each browser. Maybe we can just straight away use the right color here.
|
|
||
| &:hover { | ||
| color: initial; | ||
| background-color: initial; |
| import Popover from 'components/Popover'; | ||
| import NamespaceStore, {getCurrentNamespace} from 'services/NamespaceStore'; | ||
| import IconSVG from 'components/IconSVG'; | ||
| import {setNewNamespaces} from 'components/OpsDashboard/store/ActionCreator'; |
There was a problem hiding this comment.
nit: name this setNewNamespacesPick to make it more clear?
| </div> | ||
| ); | ||
| } else { | ||
|
|
| {monitorTitle} | ||
|
|
||
| <div className="monitor-more text-xs-right"> | ||
| <div className="d-inline-block"> |
There was a problem hiding this comment.
is this class name a typo?
There was a problem hiding this comment.
no, this is bootstrap utility class to set it to inline-block
|
Code LGTM 👍 |
elfenheart
force-pushed
the
feature/ui-ops-dahsboard-navigation
branch
from
8425745
to
6e3fb9b
Compare
JIRAs: