Enabled macros for core plugin batch sinks #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knazir
changed the title
| // do not create file system properties if macros were provided, wait for runtime | ||
| if (!this.config.containsMacro("fileSystemProperties") && !this.config.containsMacro("accessID") && | ||
| !this.config.containsMacro("accessKey")) { | ||
| this.config.fileSystemProperties = updateFileSystemProperties(this.config.fileSystemProperties, |
There was a problem hiding this comment.
the constructor is called only during test cases right, do you need this for test case fix?
|
Guild is breen: http://builds.cask.co/browse/HYP-BAD48-5 |
|
lgtm |
knazir
force-pushed
the
core-batch-sink-macros
branch
from
5423d05
to
71f8041
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following properties have had macros enabled:
S3BatchSink(s):TPFSSink(s):SnapshotFileSetSink:Also addresses this JIRA: https://issues.cask.co/browse/HYDRA-394