ensure more informative errors from dmg.rb
#4887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic for better errors was already there; this just makes sure that another exceptional case is handled, and falls through to the existing error-check. References: Homebrew#4857
rolandwalker
added a commit
that referenced
this pull request
Jun 14, 2014
ensure more informative errors from `dmg.rb`
rolandwalker
added a commit
to rolandwalker/homebrew-cask
that referenced
this pull request
Jun 15, 2014
Mysterious `hdiutil` errors are a longtime problem with the test suite, and the largest cause of false Travis failure reports. What appears to happen is that `hdiutil` returns a valid plist output, but also exits with an error code. Recently, user errors have been reported which seem to be related to the same problem (Homebrew#4857). After Homebrew#4892 and Homebrew#4887, we have have more assurances that mount errors will be caught elsewhere, if the XML is incorrect/missing, or if the mounts are not returned. So, for this special case, it should be safe to simply ignore the error code from `hdiutil`.
rolandwalker
added a commit
to rolandwalker/homebrew-cask
that referenced
this pull request
Jun 25, 2014
- Raise `CaskError` instead of `Plist::ParseError` from module - Improve error message when parse result is empty - remove leading garbage text and emit it to stderr (seen in Homebrew#5060) - remove trailing garbage text and emit it to stderr (seen in Homebrew#4819) This has the incidental effect of emitting DMG licenses during installation, which seems desirable as permanent functionality. If not permanent, the warnings to STDERR should still be kept temporarily to help get better bug reports on `hdiutil`. A bug wrt DMG licenses must have been introduced in one of Homebrew#4892, Homebrew#4887, Homebrew#4889, Homebrew#4900, Homebrew#4975, Homebrew#4978, or Homebrew#4857. Presumably, the cause is that STDERR was previously silenced when running `hdiutil`. It would be cleaner (and more reliable) to redirect STDERR and examine it separately, rather than clean up the merged outputs. closes Homebrew#4819 closes Homebrew#5060
This was referenced Jun 25, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for better errors was already there; this just makes
sure that another exceptional case is handled, and falls through
to the existing error-check.
References: #4857