Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust to Homebrew's test environment changes #4982

Merged
merged 3 commits into from Jun 19, 2014

Conversation

rolandwalker
Copy link
Contributor

Homebrew has been changing their test infrastructure quite a bit.

The logs say they are switching to Minitest, and a refactor seems to be happening.

These changes are imperfect, but without them, Travis is going to start reporting
failures 100% of the time.

  • minitest-colorize disabled, should find a way to re-enable it
  • global shutup method defined, should use Homebrew's new version instead

Sync up with Homebrew.  Solves the following problem:
```bash
$ bundle exec rake test
... minitest/unit.rb:19:in `const_missing': uninitialized constant MiniTest::Test (NameError)
	from /usr/local/Library/Homebrew/test/testing_env.rb:91:in `<module:Homebrew>'
    ...
```
solves this error:
```bash
$ bundle exec rake test
...lib/minitest/colorize.rb:88:in `<top (required)>': undefined method `output=' for Minitest::Unit:Class (NoMethodError)
...
```
solves the following error:
```bash
$ bundle exec rake test
...
NoMethodError: undefined method `shutup'
...
```

This is not a permanent solution.  The test suite should be changed
around to find the new `shutup` method, which is still in Homebrew,
but no longer global.
@rolandwalker
Copy link
Contributor Author

@caskroom/maintainers , I am merging this immediately, to try to get Travis back in a working state.

rolandwalker added a commit that referenced this pull request Jun 19, 2014
Adjust to Homebrew's test environment changes
@rolandwalker rolandwalker merged commit d3278a5 into Homebrew:master Jun 19, 2014
@rolandwalker rolandwalker deleted the test_env_changes branch June 19, 2014 14:17
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant