Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create "internal use" command verbs: _dump, _help #5011

Merged
merged 14 commits into from Jun 21, 2014
Merged

create "internal use" command verbs: _dump, _help #5011

merged 14 commits into from Jun 21, 2014

Conversation

rolandwalker
Copy link
Contributor

  • based on abstract class Cask::CLI::InternalUseBase
  • internal-use class file names follow internal_<verb>.rb, but the "internal" is dropped for the CLI
  • internal-use verbs start with underscore at CLI
  • internal-use verbs are invisible in the regular usage document
  • This PR adds _dump command
  • adds _help command
  • includes refactoring of cli.rb and cli/*.rb
  • this is intended as a playground for new functionality eg _appcast
  • no tests on internal verbs: they are always considered unspecified and unstable

@rolandwalker rolandwalker changed the title create "internal use" command verbs: _dump, _help WIP create "internal use" command verbs: _dump, _help Jun 20, 2014
@rolandwalker rolandwalker changed the title WIP create "internal use" command verbs: _dump, _help create "internal use" command verbs: _dump, _help Jun 20, 2014
@rolandwalker
add command_classes method
5206d2b
@rolandwalker
recast help/usage with command_classes
eb99afc 
invoking new `command_name` method from the base class when the
command verb string is needed
@rolandwalker
recast commands method using command_classes
5c6a876 
no longer a need for hardcoding constants to remove (such as
`:ISSUES_URL`), because `command_classes` checks for a `run`
method.
@rolandwalker
simplify lookup_command
604aaad 
by `zip`ping `commands` with `command_classes`
@rolandwalker
create "internal use" command verbs
8163745 
- based on abstract class `Cask::CLI::InternalUseBase`
- interal-use class file names follow `internal_<verb>.rb`, but the "internal" is dropped for the CLI
- internal-use verbs start with underscore at CLI
- internal-use verbs are invisible in the usage document
@rolandwalker
add _dump internal-use verb
204bbe8
@rolandwalker
add _help internal command
a0e061b
@rolandwalker
refactor variable name max_command_len
b395df5
@rolandwalker
add blank line to NullCommand message
584f77b
@rolandwalker
whitespace
785da0c
rolandwalker added a commit that referenced this pull request Jun 21, 2014
@rolandwalker
Merge pull request #5011 from rolandwalker/internal_command_dump
ddb9322 
create "internal use" command verbs: _dump, _help
@rolandwalker rolandwalker merged commit ddb9322 into Homebrew:master Jun 21, 2014
@rolandwalker rolandwalker deleted the internal_command_dump branch June 21, 2014 14:46
@rolandwalker rolandwalker mentioned this pull request Jul 23, 2014
Closed
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@rolandwalker