-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update perforce.rb, remove p4.rb #29180
Conversation
Are these the same perforce product? I know there's a p4 cask also |
Is it possible to disable the hash comparison for this cask? I know it is a bad idea as you can never know what binary you are dealing with... but Perforce changes these files all the time. Example from the past: Homebrew/legacy-homebrew#21799 |
@larsxschneider done, thanks for the information. Ping @adidalal for final review. |
I think the name p4d was available here: https://github.com/Homebrew/homebrew-binary/blob/master/perforce-server.rb |
Ping @vitorgalvao RE the token reference.
The whole point of this is to migrate all formula from hombrew-binary - see https://github.com/Homebrew/homebrew-binary/pull/364. |
I would prefer 'perforce' as name but I am fine with 'helix-versioning-engine', too. Thanks a lot for working on this! |
The git core TravisCI builds are blocked because of the Perforce ... I am looking forward to your merged patch 😄 |
No problem. |
I’m fine with either name. Since this is binary-only, the token reference doesn’t apply, but it does seem like users might expect |
I think Thanks @vitorgalvao. |
Let's also add in a json entry for the redirect. Otherwise looks good |
Yes, I will once https://github.com/Homebrew/homebrew-binary/pull/364 is merged. Thanks @adidalal. |
Just to clarify, I meant p4 -> perforce (both Casks, but p4 is being renamed? now, so it makes sense to have that redirect there also) |
Yes, I will fix it all, no problem. |
Closed by mistake. |
Not sure why Travis is lagging but LGTM from looking at the cask |
Thanks @adidalal - there are only three remaining in homebrew-binary, namely eventstore.rb, mpress.rb and subgit.rb, which seem quite a bit more complicated than those I have already done. I may need some help with those ones. |
Just double check with @MikeMcQuaid about usage stats for those before putting in significant effort. All in all though, fantastic work! |
Thanks @adidalal - I am pretty sure @MikeMcQuaid has already removed a fair few based on the analytics statistics, so those that are left are used. |
Well, the homebrew-binary formula for
and running Thoughts @MikeMcQuaid? |
There is also a problem with the homebrew-binary formula for |
And finally, I have no idea how to create a Cask for I understand how the formula works, but have no idea how to translate what it does to a Cask. |
You've done a great job @miccal, well done. |
Update: |
The `perforce` and `perforce-server` package were moved from brew [1][2] to cask [3]. Teach TravisCI the new location. Perforce updates their binaries without version bumps. That made the brew install (legitimately!) fail due to checksum mismatches. The workaround is not necessary anymore as Cask [4] allows to disable the checksum test for individual formulas. [1] https://github.com/Homebrew/homebrew-binary/commit/1394e42de04d07445f82f9512627e864ff4ca4c6 [2] https://github.com/Homebrew/homebrew-binary/commit/f8da22d6b8dbcfcfdb2dfa9ac1a5e5d8e05aac2b [3] Homebrew/homebrew-cask#29180 [4] https://caskroom.github.io/ Signed-off-by: Lars Schneider <larsxschneider@gmail.com>
Everything works perfectly! Thank you! |
The `perforce` and `perforce-server` package were moved from brew [1][2] to cask [3]. Teach TravisCI the new location. Perforce updates their binaries without version bumps. That made the brew install (legitimately!) fail due to checksum mismatches. The workaround is not necessary anymore as Cask [4] allows to disable the checksum test for individual formulas. [1] https://github.com/Homebrew/homebrew-binary/commit/1394e42de04d07445f82f9512627e864ff4ca4c6 [2] https://github.com/Homebrew/homebrew-binary/commit/f8da22d6b8dbcfcfdb2dfa9ac1a5e5d8e05aac2b [3] Homebrew/homebrew-cask#29180 [4] https://caskroom.github.io/ Signed-off-by: Lars Schneider <larsxschneider@gmail.com>
The `perforce` and `perforce-server` package were moved from brew [1][2] to cask [3]. Teach TravisCI the new location. Perforce updates their binaries without version bumps. That made the brew install (legitimately!) fail due to checksum mismatches. The workaround is not necessary anymore as Cask [4] allows to disable the checksum test for individual formulas. [1] https://github.com/Homebrew/homebrew-binary/commit/1394e42de04d07445f82f9512627e864ff4ca4c6 [2] https://github.com/Homebrew/homebrew-binary/commit/f8da22d6b8dbcfcfdb2dfa9ac1a5e5d8e05aac2b [3] Homebrew/homebrew-cask#29180 [4] https://caskroom.github.io/ Signed-off-by: Lars Schneider <larsxschneider@gmail.com>
The `perforce` and `perforce-server` package were moved from brew [1][2] to cask [3]. Teach TravisCI the new location. Perforce updates their binaries without version bumps. That made the brew install (legitimately!) fail due to checksum mismatches. The workaround is not necessary anymore as Cask [4] allows to disable the checksum test for individual formulas. [1] https://github.com/Homebrew/homebrew-binary/commit/1394e42de04d07445f82f9512627e864ff4ca4c6 [2] https://github.com/Homebrew/homebrew-binary/commit/f8da22d6b8dbcfcfdb2dfa9ac1a5e5d8e05aac2b [3] Homebrew/homebrew-cask#29180 [4] https://caskroom.github.io/ Signed-off-by: Lars Schneider <larsxschneider@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
The `perforce` and `perforce-server` package were moved from brew [1][2] to cask [3]. Teach TravisCI the new location. Perforce updates their binaries without version bumps. That made the brew install (legitimately!) fail due to checksum mismatches. The workaround is not necessary anymore as Cask [4] allows to disable the checksum test for individual formulas. [1] https://github.com/Homebrew/homebrew-binary/commit/1394e42de04d07445f82f9512627e864ff4ca4c6 [2] https://github.com/Homebrew/homebrew-binary/commit/f8da22d6b8dbcfcfdb2dfa9ac1a5e5d8e05aac2b [3] Homebrew/homebrew-cask#29180 [4] https://caskroom.github.io/ Signed-off-by: Lars Schneider <larsxschneider@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Adds https://github.com/Homebrew/homebrew-binary/blob/master/perforce-server.rb to the one Cask.
Ping @adidalal for review.