Update perforce.rb, remove p4.rb #29180

miccal · 2017-01-19T07:25:15Z

Adds https://github.com/Homebrew/homebrew-binary/blob/master/perforce-server.rb to the one Cask.

Ping @adidalal for review.

adidalal · 2017-01-19T11:06:12Z

Are these the same perforce product? I know there's a p4 cask also

miccal · 2017-01-19T12:21:35Z

@adidalal p4v and p4merge are different, but p4 is the same as the original perforce Cask.

miccal · 2017-01-19T12:25:51Z

Contents of helix-versioning-engine.tgz:

larsxschneider · 2017-01-19T21:01:49Z

Is it possible to disable the hash comparison for this cask? I know it is a bad idea as you can never know what binary you are dealing with... but Perforce changes these files all the time. Example from the past: Homebrew/legacy-homebrew#21799

miccal · 2017-01-19T21:07:24Z

@larsxschneider done, thanks for the information.

Ping @adidalal for final review.

larsxschneider · 2017-01-19T21:09:13Z

I think the name helix-versioning-engine could be confusion to people. It looks like as if the helix-versioning-engine.rb contains all products:
p4 (the client app) and p4d (the "daemon", server app).

p4d was available here: https://github.com/Homebrew/homebrew-binary/blob/master/perforce-server.rb

miccal · 2017-01-19T21:11:59Z

I think the name helix-versioning-engine could be confusion to people.

Ping @vitorgalvao RE the token reference.

p4d was available here: https://github.com/Homebrew/homebrew-binary/blob/master/perforce-server.rb

The whole point of this is to migrate all formula from hombrew-binary - see https://github.com/Homebrew/homebrew-binary/pull/364.

larsxschneider · 2017-01-19T21:13:32Z

I would prefer 'perforce' as name but I am fine with 'helix-versioning-engine', too. Thanks a lot for working on this!

larsxschneider · 2017-01-19T21:14:46Z

The git core TravisCI builds are blocked because of the Perforce ... I am looking forward to your merged patch 😄
https://travis-ci.org/git/git/builds

miccal · 2017-01-19T21:20:39Z

I would prefer 'perforce' as name but I am fine with 'helix-versioning-engine', too. Thanks a lot for working on this!

No problem.

vitorgalvao · 2017-01-19T23:13:46Z

I’m fine with either name. Since this is binary-only, the token reference doesn’t apply, but it does seem like users might expect p4 or perforce instead of helix-versioning-engine.

miccal · 2017-01-19T23:14:22Z

I think perforce might be better.

Thanks @vitorgalvao.

adidalal · 2017-01-20T02:40:05Z

Let's also add in a json entry for the redirect. Otherwise looks good

miccal · 2017-01-20T02:41:01Z

Let's also add in a json entry for the redirect. Otherwise looks good

Yes, I will once https://github.com/Homebrew/homebrew-binary/pull/364 is merged.

Thanks @adidalal.

adidalal · 2017-01-20T03:14:57Z

Just to clarify, I meant p4 -> perforce (both Casks, but p4 is being renamed? now, so it makes sense to have that redirect there also)

miccal · 2017-01-20T03:16:18Z

Just to clarify, I meant p4 -> perforce (both Casks, but p4 is being renamed? now, so it makes sense to have that redirect there also)

Yes, I will fix it all, no problem.

miccal · 2017-01-20T03:16:34Z

Closed by mistake.

adidalal · 2017-01-20T03:30:44Z

Not sure why Travis is lagging but LGTM from looking at the cask

miccal · 2017-01-20T03:48:23Z

Thanks @adidalal - there are only three remaining in homebrew-binary, namely eventstore.rb, mpress.rb and subgit.rb, which seem quite a bit more complicated than those I have already done.

I may need some help with those ones.

adidalal · 2017-01-20T04:07:32Z

Just double check with @MikeMcQuaid about usage stats for those before putting in significant effort. All in all though, fantastic work!

miccal · 2017-01-20T05:17:38Z

Thanks @adidalal - I am pretty sure @MikeMcQuaid has already removed a fair few based on the analytics statistics, so those that are left are used.

miccal · 2017-01-20T06:48:22Z

Well, the homebrew-binary formula for mpress is not working - when I run brew test mpress the output is:

-bash-4.4.5- /Users/raesy [> brew test mpress
Testing homebrew/binary/mpress
==> Using the sandbox
==> /usr/local/Cellar/mpress/1.21_1/bin/mpress
Error: homebrew/binary/mpress: failed
<1> expected but was
<22>.
-bash-4.4.5- /Users/raesy [>

and running mpress --version outputs nothing, so I cannot test a Cask install via a comparison with a homebrew-binary install.

Thoughts @MikeMcQuaid?

miccal · 2017-01-20T07:03:15Z

There is also a problem with the homebrew-binary formula for subgit - I modified the formula to use the latest version (3.2.3 instead of 3.2.0) and update the download url, but there is no test with this formula, and running any command (for example subgit --version) returns Unable to find any JVMs matching version "(null)". and request that I install Java (which I do not really want to do), so I cannot test a Cask install via a comparison with a homebrew-binary install on subgit either.

miccal · 2017-01-20T07:51:06Z

And finally, I have no idea how to create a Cask for eventstore, it is beyond my skills, sorry.

I understand how the formula works, but have no idea how to translate what it does to a Cask.

MikeMcQuaid · 2017-01-20T08:05:54Z

You've done a great job @miccal, well done.

miccal · 2017-01-20T09:58:57Z

Update: subgit was actually quite straight-forward once I played around with it. Added here.

The `perforce` and `perforce-server` package were moved from brew [1][2] to cask [3]. Teach TravisCI the new location. Perforce updates their binaries without version bumps. That made the brew install (legitimately!) fail due to checksum mismatches. The workaround is not necessary anymore as Cask [4] allows to disable the checksum test for individual formulas. [1] https://github.com/Homebrew/homebrew-binary/commit/1394e42de04d07445f82f9512627e864ff4ca4c6 [2] https://github.com/Homebrew/homebrew-binary/commit/f8da22d6b8dbcfcfdb2dfa9ac1a5e5d8e05aac2b [3] Homebrew/homebrew-cask#29180 [4] https://caskroom.github.io/ Signed-off-by: Lars Schneider <larsxschneider@gmail.com>

larsxschneider · 2017-01-21T14:45:22Z

Everything works perfectly! Thank you!

The `perforce` and `perforce-server` package were moved from brew [1][2] to cask [3]. Teach TravisCI the new location. Perforce updates their binaries without version bumps. That made the brew install (legitimately!) fail due to checksum mismatches. The workaround is not necessary anymore as Cask [4] allows to disable the checksum test for individual formulas. [1] https://github.com/Homebrew/homebrew-binary/commit/1394e42de04d07445f82f9512627e864ff4ca4c6 [2] https://github.com/Homebrew/homebrew-binary/commit/f8da22d6b8dbcfcfdb2dfa9ac1a5e5d8e05aac2b [3] Homebrew/homebrew-cask#29180 [4] https://caskroom.github.io/ Signed-off-by: Lars Schneider <larsxschneider@gmail.com>

The `perforce` and `perforce-server` package were moved from brew [1][2] to cask [3]. Teach TravisCI the new location. Perforce updates their binaries without version bumps. That made the brew install (legitimately!) fail due to checksum mismatches. The workaround is not necessary anymore as Cask [4] allows to disable the checksum test for individual formulas. [1] https://github.com/Homebrew/homebrew-binary/commit/1394e42de04d07445f82f9512627e864ff4ca4c6 [2] https://github.com/Homebrew/homebrew-binary/commit/f8da22d6b8dbcfcfdb2dfa9ac1a5e5d8e05aac2b [3] Homebrew/homebrew-cask#29180 [4] https://caskroom.github.io/ Signed-off-by: Lars Schneider <larsxschneider@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

miccal added 2 commits January 19, 2017 15:24

Update perforce.rb

b2a6dee

Update perforce.rb

0401ade

miccal mentioned this pull request Jan 19, 2017

Migrate perforce from homebrew-binary #29065

Merged

8 tasks

miccal added 3 commits January 20, 2017 05:02

Delete p4.rb

bc00a76

Update perforce.rb

bd303ac

Rename perforce.rb to helix-versioning-engine.rb

4d38fb9

miccal changed the title ~~Update perforce.rb~~ Update and rename perforce.rb to helix-versioning-engine.rb, remove p4.rb Jan 19, 2017

Update helix-versioning-engine.rb

c7a9ec9

name of the vendor also belongs in name stanza

97fbc5d

Update and rename helix-versioning-engine.rb to perforce.rb

dafa4b3

miccal changed the title ~~Update and rename perforce.rb to helix-versioning-engine.rb, remove p4.rb~~ Update perforce.rb, remove p4.rb Jan 19, 2017

miccal closed this Jan 20, 2017

miccal reopened this Jan 20, 2017

adidalal approved these changes Jan 20, 2017

View reviewed changes

miccal merged commit ae8d73b into master Jan 20, 2017

miccal deleted the miccal-perforce branch January 20, 2017 07:11

Homebrew locked and limited conversation to collaborators May 9, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update perforce.rb, remove p4.rb #29180

Update perforce.rb, remove p4.rb #29180

miccal commented Jan 19, 2017 •

edited

adidalal commented Jan 19, 2017

miccal commented Jan 19, 2017 •

edited

miccal commented Jan 19, 2017

larsxschneider commented Jan 19, 2017

miccal commented Jan 19, 2017 •

edited

larsxschneider commented Jan 19, 2017

miccal commented Jan 19, 2017 •

edited

larsxschneider commented Jan 19, 2017

larsxschneider commented Jan 19, 2017

miccal commented Jan 19, 2017 •

edited

vitorgalvao commented Jan 19, 2017

miccal commented Jan 19, 2017 •

edited

adidalal commented Jan 20, 2017

miccal commented Jan 20, 2017 •

edited

adidalal commented Jan 20, 2017

miccal commented Jan 20, 2017

miccal commented Jan 20, 2017

adidalal commented Jan 20, 2017

miccal commented Jan 20, 2017

adidalal commented Jan 20, 2017

miccal commented Jan 20, 2017 •

edited

miccal commented Jan 20, 2017 •

edited

miccal commented Jan 20, 2017 •

edited

miccal commented Jan 20, 2017 •

edited

MikeMcQuaid commented Jan 20, 2017

miccal commented Jan 20, 2017 •

edited

larsxschneider commented Jan 21, 2017

Update perforce.rb, remove p4.rb #29180

Update perforce.rb, remove p4.rb #29180

Conversation

miccal commented Jan 19, 2017 • edited

adidalal commented Jan 19, 2017

miccal commented Jan 19, 2017 • edited

miccal commented Jan 19, 2017

larsxschneider commented Jan 19, 2017

miccal commented Jan 19, 2017 • edited

larsxschneider commented Jan 19, 2017

miccal commented Jan 19, 2017 • edited

larsxschneider commented Jan 19, 2017

larsxschneider commented Jan 19, 2017

miccal commented Jan 19, 2017 • edited

vitorgalvao commented Jan 19, 2017

miccal commented Jan 19, 2017 • edited

adidalal commented Jan 20, 2017

miccal commented Jan 20, 2017 • edited

adidalal commented Jan 20, 2017

miccal commented Jan 20, 2017

miccal commented Jan 20, 2017

adidalal commented Jan 20, 2017

miccal commented Jan 20, 2017

adidalal commented Jan 20, 2017

miccal commented Jan 20, 2017 • edited

miccal commented Jan 20, 2017 • edited

miccal commented Jan 20, 2017 • edited

miccal commented Jan 20, 2017 • edited

MikeMcQuaid commented Jan 20, 2017

miccal commented Jan 20, 2017 • edited

larsxschneider commented Jan 21, 2017

miccal commented Jan 19, 2017 •

edited

miccal commented Jan 19, 2017 •

edited

miccal commented Jan 19, 2017 •

edited

miccal commented Jan 19, 2017 •

edited

miccal commented Jan 19, 2017 •

edited

miccal commented Jan 19, 2017 •

edited

miccal commented Jan 20, 2017 •

edited

miccal commented Jan 20, 2017 •

edited

miccal commented Jan 20, 2017 •

edited

miccal commented Jan 20, 2017 •

edited

miccal commented Jan 20, 2017 •

edited

miccal commented Jan 20, 2017 •

edited