Skip to content
This repository has been archived by the owner on May 2, 2024. It is now read-only.

Add Safari Technology Preview.app #1865

Closed
wants to merge 1 commit into from
Closed

Add Safari Technology Preview.app #1865

wants to merge 1 commit into from

Conversation

jodelamo
Copy link
Contributor

No description provided.

@vitorgalvao vitorgalvao mentioned this pull request Mar 31, 2016
Closed
@vitorgalvao
Copy link
Member

Leaving on hold.

vitorgalvao
vitorgalvao reviewed Mar 31, 2016
View reviewed changes
Casks/safari-technology-preview.rb

pkg 'Safari Technology Preview for OS X El Capitan.pkg'

uninstall delete: '/Applications/Safari Technology Preview.app'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this is the only thing that is modified via the pkg?

@vitorgalvao vitorgalvao added the awaiting user reply Issue needs response from a user. label Mar 31, 2016
@jodelamo
Copy link
Contributor Author

@vitorgalvao Updated with relevant plist. Thanks for the heads up.

@jodelamo jodelamo closed this Mar 31, 2016
@jodelamo
Copy link
Contributor Author

@vitorgalvao Aaaand closed it by mistake...

@jodelamo jodelamo reopened this Mar 31, 2016
@alrra alrra mentioned this pull request Mar 31, 2016
Closed
2 tasks
vitorgalvao
vitorgalvao reviewed Mar 31, 2016
View reviewed changes
Casks/safari-technology-preview.rb

pkg 'Safari Technology Preview for OS X El Capitan.pkg'

uninstall pkgutil: 'com.apple.SafariTechnologyPreview.plist',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn’t this just a preferences file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vitorgalvao Updated.

@vitorgalvao
Copy link
Member

We’ve decided to go with this repo. Mind copying over the other improvements to the zap from the other one?

Eitot
Eitot reviewed Apr 3, 2016
View reviewed changes
Casks/safari-technology-preview.rb
url 'https://secure-appldnld.apple.com/STP/SafariTechnologyPreview.dmg'
name 'Safari Technology Preview'
homepage 'https://developer.apple.com/safari/technology-preview/'
license :unknown
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be :gratis.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically yes, in practice it no longer matters.

@zmwangx
Copy link
Contributor

zmwangx commented Apr 4, 2016

The files deleted under the zap stanza here are totally wrong. Please take a look at https://github.com/caskroom/homebrew-cask/pull/20171/files.

@adidalal
Copy link
Contributor

adidalal commented Apr 4, 2016

Thank you for the contribution. It needed some fixes, so they were made in fff160a. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.

Changes made from @zmwangx, thanks!

@adidalal adidalal closed this Apr 4, 2016
@jodelamo
Copy link
Contributor Author

jodelamo commented Apr 4, 2016

@zmwangx Gah. Copy paste fail. It was the result of

find . -type f -iname "*technologypreview*"

Problem is I was in the ~/Library folder as I executed it. 😄

@zmwangx zmwangx mentioned this pull request Apr 4, 2016
Merged
@miccal miccal removed the awaiting user reply Issue needs response from a user. label Dec 23, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jodelamo @vitorgalvao @zmwangx @adidalal @Eitot @miccal