Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: inject secret store csi driver #1

Closed
wants to merge 3 commits into from

Conversation

omar-devolute
Copy link

@omar-devolute omar-devolute commented Jul 14, 2023

Description

Fixes #118.

In the deployment_spec.tpl we must allow a new as value to be passed to a secret block, we call this new type "csi".

Receiving this type of secret has to mix functionality of both volumes and environment as we will require a env block and a volumeMounts

Steps

  • add template test - to check a csi block is passed to the secret
  • modify deployment_spec.tpl so that it can accept "csi" for the values of the "as" and test the template builds appropriately
  • add test for csi secret store - that the nginx is built correctly (have to install the helm charts for the secret store)
  • find secret related documentation to add details of how this works and how to test it

TODOs

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Include release notes.

Release Notes (draft)

Allow secrets to be of type CSI allowing the injection of Secret Store CSI driver configuration to the deployment

Migration Guide

@omar-devolute omar-devolute changed the title Cs 1749 adding test csi driver feat: inject secret store csi driver Jul 14, 2023
@omar-devolute omar-devolute marked this pull request as draft July 14, 2023 13:26
@omar-devolute omar-devolute force-pushed the CS-1749-adding-test-csi-driver branch 4 times, most recently from c580b1a to d8708c2 Compare July 14, 2023 14:21
- added a row to features section
- added csi block in the volumes section
- tpl needs a mix of funcitonality from volume and env types of secrets
-  added service account name to test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants