-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GetBlockResult #107
Merged
zacshowa
merged 12 commits into
casper-ecosystem:feat-track-node-2.0
from
zacshowa:get_block_fix
Oct 3, 2023
Merged
Update GetBlockResult #107
zacshowa
merged 12 commits into
casper-ecosystem:feat-track-node-2.0
from
zacshowa:get_block_fix
Oct 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ures` via types.rs for use in `GetBlockResult` Signed-off-by: Zach Showalter <zach@casperlabs.io>
Signed-off-by: Zach Showalter <zach@casperlabs.io>
Signed-off-by: Zach Showalter <zach@casperlabs.io>
…tBlockResult` Signed-off-by: Zach Showalter <zach@casperlabs.io>
Signed-off-by: Zach Showalter <zach@casperlabs.io>
Signed-off-by: Zach Showalter <zach@casperlabs.io>
Signed-off-by: Zach Showalter <zach@casperlabs.io>
gRoussac
approved these changes
Sep 19, 2023
Cargo.toml
Outdated
@@ -33,9 +33,9 @@ num-traits = "0.2.15" | |||
once_cell = "1" | |||
rand = "0.8.5" | |||
reqwest = { version = "0.11.13", features = ["json"] } | |||
schemars = "0.8" | |||
schemars = "0.8.12" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I had issues in 0.8 so I had 0.8.13 in my PR, maybe you can try 13 too ? thanks
Fraser999
reviewed
Sep 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor points - should be trivial to fix up.
Co-authored-by: Fraser Hutchison <190532+Fraser999@users.noreply.github.com>
Co-authored-by: Fraser Hutchison <190532+Fraser999@users.noreply.github.com>
Co-authored-by: Fraser Hutchison <190532+Fraser999@users.noreply.github.com>
Co-authored-by: Fraser Hutchison <190532+Fraser999@users.noreply.github.com>
Signed-off-by: Zach Showalter <zach@casperlabs.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of work done:
JsonBlockWithSignatures
to typesGetBlockResult
to contain aJsonBlockWithSignatures
, rather than a BlockFrom<GetBlockResult>
forListDeploysResult
Sample request:
Request for a specific block from an NCTL network
Associated output:
Request for the most recent block from an NCTL network by providing no block identifier
Associated output:
Associated ticket(s):
#108
Ticket #108