Implemented "account_put_transaction" method. Added TransactionUtil.t… #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zajko
force-pushed
the
account_put_transaction_method
branch
from
e62c7e8
to
da9a85e
Compare
zajko
commented
Jun 4, 2024
| * @param publicKey CLPublicKey instance | ||
| * @param transferId BigNumberish value (can be also string representing number). Max U64. | ||
| */ | ||
| constructor(publicKey: CLPublicKey, transferId: BigNumberish) { |
There was a problem hiding this comment.
Types used with @JsonObject and TypedJson generally require a no-args constructor
…s as an implementation for DTO of Transaction entity
zajko
force-pushed
the
account_put_transaction_method
branch
from
da9a85e
to
a1e107b
Compare
…t_transaction' test
hoffmannjan
approved these changes
Jun 10, 2024
ryo-casper
approved these changes
Jun 10, 2024
| @@ -247,6 +258,67 @@ describe('CasperServiceByJsonRPC', () => { | |||
| expect(balanceByUref.eq(balanceByPublicKey)).to.be; | |||
| }); | |||
|
|
|||
| it.only('should transfer CSPR - account_put_transaction', async () => { | |||
There was a problem hiding this comment.
could you please remove .only?
Comment on lines
+11
to
+13
| export const byteArrayJsonSerializer: (bytes: Uint8Array) => string = ( | ||
| bytes: Uint8Array | ||
| ) => { |
There was a problem hiding this comment.
NIT
Suggested change
| export const byteArrayJsonSerializer: (bytes: Uint8Array) => string = ( | |
| bytes: Uint8Array | |
| ) => { | |
| export const byteArrayJsonSerializer = ( bytes: Uint8Array ): string => { |
| if (transaction.Deploy) { | ||
| signDeploy(transaction.Deploy, signingKey); | ||
| return transaction; | ||
| } else if (transaction.Version1) { |
There was a problem hiding this comment.
if possible, could we split this into signTransactionV1?
| * @param payment The payment logic of the deploy | ||
| * @returns A new `Transaction` object | ||
| */ | ||
| export function makeV1Transaction( |
There was a problem hiding this comment.
NIT: please keep consistency for naming; TransactionV1 or V1Transaction
| @@ -113,6 +116,7 @@ export interface ValidatorsInfoResult extends RpcResult { | |||
|
|
|||
| /** JSON RPC service for interacting with Casper nodes */ | |||
| export class CasperServiceByJsonRPC { | |||
| oneMegaByte = 1048576; | |||
There was a problem hiding this comment.
NIT: Well, I know this comes from the, old code, but for human readability, what about 1 * 1024 * 1024?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s as an implementation for DTO of Transaction entity