Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checksum for target account hash #1415

Closed
9 tasks done
piotr-dziubecki opened this issue May 10, 2021 · 0 comments
Closed
9 tasks done

Checksum for target account hash #1415

piotr-dziubecki opened this issue May 10, 2021 · 0 comments
Assignees
Milestone

Comments

@piotr-dziubecki
Copy link

piotr-dziubecki commented May 10, 2021

Implement CEP-57.

There is already a draft PR #1557

Needs the following touch-ups before it is merged:

  • Tests fixed since @afck and I changed the scheme to use our hash entropy efficiently
  • Rebase to dev
  • Optimizations
    • Replace blake2bhash which returns a Vec with something that returns [u8; 32] so we avoid using the heap
    • Reduce the number of passes over the hex string in decode to at most 2
    • Make it so decode doesn’t do any heap allocations
    • Simplify for loops to use iteration instead
  • Remove all hex external crate dependencies
  • Benchmarks: run cargo bench --bench transfer_bench -- --save-baseline 'dev' on dev branch, then on this branch run cargo bench --bench transfer_bench -- --baseline 'dev'
@xcthulhu xcthulhu added this to the 1.4.0 milestone Jun 9, 2021
@xcthulhu xcthulhu assigned nilz3ro and unassigned xcthulhu Aug 5, 2021
@nilz3ro nilz3ro linked a pull request Aug 12, 2021 that will close this issue
@piotr-dziubecki piotr-dziubecki modified the milestones: 1.4.0, 1.5.0 Sep 16, 2021
casperlabs-bors-ng bot added a commit that referenced this issue Oct 21, 2021
2179: Checksummed hex r=nilz3ro a=nilz3ro

# About These Changes
* Replaces #1900.
* Brings #1557 up to speed with dev.
* For more info, see comprehensive issue #1415

Co-authored-by: Matthew Doty <mpwd@casperlabs.io>
Co-authored-by: Austin Buddington <austin@casperlabs.io>
Co-authored-by: Austin Buddington <austin.j.buddington@gmail.com>
Co-authored-by: Fraser Hutchison <fraser@casperlabs.io>
@nilz3ro nilz3ro closed this as completed Oct 22, 2021
@cspramit cspramit modified the milestones: 1.5.0, 1.4.2 Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants