Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align the changes to rewards made for "private chain" and for "2.0" #4254

Closed
RitaMAllenCA opened this issue Aug 30, 2023 · 0 comments · Fixed by #4321
Closed

Align the changes to rewards made for "private chain" and for "2.0" #4254

RitaMAllenCA opened this issue Aug 30, 2023 · 0 comments · Fixed by #4321
Assignees

Comments

@RitaMAllenCA
Copy link

RitaMAllenCA commented Aug 30, 2023

Recently we did a merge of dev to feat-2.0. Because both branches tackled with rewards calculation, there is a TODO added in era_supervisor.rs to remind that we need to verify if we support the compute_rewards chainspec flag correctly in in 2.0. Details here.

TODO:

  1. Merge feat-2.0 into feat-signature-rewards (bring data extensibility and private chain changes into rewards feature branch)
  2. Check if the private chain changes to rewards work correctly with the rewards changes on the feature branch
  3. Optionally (but preferably) merge feat-signature-rewards back to feat-2.0
@real-felix real-felix linked a pull request Oct 5, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants