-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge feat 2.0 #4321
Merge feat 2.0 #4321
Conversation
…ity-signature Add the Past Finality Signatures
…inality-signatures-payload Populate the PastFinalitySignatures field in the block body
…of-lag Change the reward scheme to a blocks window instead of a delay
…l-supply Allow to query the total supply from the contract runtime
bors try |
tryBuild failed: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
bors r+ |
4321: Merge feat 2.0 r=Boiethios a=Boiethios Merge the feature branch with rewarded signatures with 2.0 To make that possible, the block header is now versioned. Co-authored-by: Félix <felix@casperlabs.io> Co-authored-by: Bartłomiej Kamiński <bart@casperlabs.io> Co-authored-by: Félix / Felix <Boiethios@users.noreply.github.com> Co-authored-by: Alexander Limonov <51098682+AlexanderLimonov@users.noreply.github.com> Co-authored-by: Luca B <93586856+bradjohnl@users.noreply.github.com>
Build failed: |
bors try |
tryBuild succeeded: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the rewards distribution tests and the ExecutableBlock
changes and both are looking good, with minor nitpicks 👍 As for the rest, we might have to rely on the tests and fix the issues as they appear 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the ExecutableBlock
change and it looks good to me with only a new minor naming nits.
bors r+ |
4321: Merge feat 2.0 r=Boiethios a=Boiethios Merge the feature branch with rewarded signatures with 2.0 To make that possible, the block header is now versioned. Co-authored-by: Félix <felix@casperlabs.io> Co-authored-by: Bartłomiej Kamiński <bart@casperlabs.io> Co-authored-by: Félix / Felix <Boiethios@users.noreply.github.com> Co-authored-by: Alexander Limonov <51098682+AlexanderLimonov@users.noreply.github.com> Co-authored-by: Luca B <93586856+bradjohnl@users.noreply.github.com>
Timed out. |
bors merge |
Build succeeded: |
ece8660
into
casper-network:feat-2.0
Merge the feature branch with rewarded signatures with 2.0
To make that possible, the block header is now versioned.