EE-1221: Increase create purse / mint entry point cost #1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpapierski
requested review from
xcthulhu,
Fraser999,
dwerner,
henrytill,
darthsiroftardis and
EdHastingsCasperAssociation
mpapierski
force-pushed
the
ee-1221-create-purse-price
branch
from
42adf10
to
6523512
Compare
darthsiroftardis
approved these changes
Apr 19, 2021
| @@ -23,7 +23,7 @@ const DEFAULT_ADD_COST: u32 = 5_800; | |||
| const DEFAULT_CALL_CONTRACT_COST: u32 = 4_500; | |||
| const DEFAULT_CALL_CONTRACT_ARGS_SIZE_WEIGHT: u32 = 420; | |||
|
|
|||
| const DEFAULT_CREATE_PURSE_COST: u32 = 170_000; | |||
| const DEFAULT_CREATE_PURSE_COST: u32 = 1_700_000; | |||
There was a problem hiding this comment.
shouldn't this also be 2_500_000_000; ?
added 4 commits
May 21, 2021 18:45
This change first creates a purse and saves them in the account's context which will be later retrieved under payment code. This is due to the fact that create_purse would always trigger GasLimit error.
mpapierski
added
the
upgrade-safe
Fraser999
approved these changes
Aug 3, 2021
Conflicts: execution_engine/CHANGELOG.md
|
bors r+ |
|
Build succeeded: |
goral09
reviewed
Aug 6, 2021
| @@ -18,6 +18,7 @@ All notable changes to this project will be documented in this file. The format | |||
|
|
|||
| ### Changed | |||
| * Support building and testing using stable Rust. | |||
| * Changed price of `create_purse` to 2.5CSPR to discourage people from creating purses in the payment code. | |||
There was a problem hiding this comment.
The "in the payment code" is confusing b/c it increases the price across the whole execution, including session code. Is that correct @mpapierski ?
There was a problem hiding this comment.
Correct, but it was increased specifically to disallow creating those in the payment code.
There was a problem hiding this comment.
But the comment makes it sound as if the cost is increased only in the payment code. I don't think the last part needs to be included in the changelog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://casperlabs.atlassian.net/browse/EE-1221
To discourage creating many empty purses to deplete storage resources, this PR is increasing create_purse/mint cost to 2.5cspr.