Add "query_global_state" query RPC to node #1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darthsiroftardis
requested review from
xcthulhu,
Fraser999,
nilz3ro and
EdHastingsCasperAssociation
darthsiroftardis
changed the title
# Conflicts: # client/src/main.rs # client/src/query_state.rs
Fraser999
requested changes
Aug 8, 2021
There was a problem hiding this comment.
There should be a casper_query_global_state() function added to the FFI, and casper_get_item should have the #[deprecated] attribute applied similar to the one suggested for get_item().
Also, there should be test cases for this new functionality added to integration_test.rs.
Fraser999
reviewed
Aug 10, 2021
Fraser999
approved these changes
Aug 13, 2021
|
bors r+ |
|
Build failed: |
|
bors try |
tryBuild succeeded: |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG:
BlockHashorstate_root_hashparam to make query toGlobalStateGlobalStateIdentifierenum to the rpcs to support the queryquery-global-statecommand the rust client that takes in a hash which is identified as either ablockhash orstateroot hash along with akeyandpatharg (similar to the preexisting) queryPS: We could use a better distinction between the "state_get_item" query and the newly added with one this PR on the client side. I am open to suggestions for names that are more distinct
Closes: 1608