Use juliet's default timeout and timeout bubbling to make missed ACKs fatal. #4354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arriving in time a connection error
Fraser999
approved these changes
Oct 19, 2023
| let is_expired = |t: &Reverse<(Instant, IoId)>| t.0 .0 <= now; | ||
|
|
||
| // Track the number of actual timeouts hit. | ||
| let mut timed_out = 0; |
There was a problem hiding this comment.
Why bother counting them if any non-zero value triggers the error?
There was a problem hiding this comment.
They are logged. In general, the info is free, so I thought it best to not just discard it in the library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition to #4269.
julietmeans (default timeout), instead of requiring special node logic.