RPC sidecar changes #4491
RPC sidecar changes #4491
Conversation
…ver sections in config
…t_trie` config values
There was a problem hiding this comment.
Approved subject to reactor test having timeouts applied, and with the various unresolved issues being discussed/ticketed soon.
These are:
- speculative exec needs to be able to be disabled (and should be by default)
- errors returned should give the client of the sidecar meaningful info
- the two different
Transformstructs should get versioned - how we handle/set
max_request_size_bytesandmax_response_size_bytesshould be reviewed - whether the REST server should still serve the sidecar's JSON-RPC schema or not
It should not. That functionality should be moved to the sidecar. Good catch. |
Agreed.
Wouldn't that be a requirement on the sidecar itself rather than this PR? Can you elaborate on your concern?
Can you elaborate? |
I think the sidecar won't be able to give the level of detail clients currently get via error messages if we don't provide that info to the sidecar via the response from the node.
There's a discussion here (you'll probably need to expand the hidden items to see it) or maybe this link won't need expanding. |
|
bors r+ |
4491: RPC sidecar changes r=jacek-casper a=jacek-casper This PR includes: - addition of a TCP listener in the node that will be handling requests from the RPC sidecar - NCTL changes necessary to pull, build and run the sidecar alongside the nodes - a specification of the binary protocol - some changes to casper-types to expose types needed for the sidecar to work - removal of the existing RPC server The purpose of this PR is to get a high-level review, there are still minor changes being done and unit tests being added. PR for the addition of the sidecar: casper-network/casper-sidecar#231 Co-authored-by: Rafał Chabowski <rafal@casperlabs.io> Co-authored-by: Jacek Malec <145967538+jacek-casper@users.noreply.github.com>
|
Canceled. |
|
bors r+ |
4491: RPC sidecar changes r=jacek-casper a=jacek-casper This PR includes: - addition of a TCP listener in the node that will be handling requests from the RPC sidecar - NCTL changes necessary to pull, build and run the sidecar alongside the nodes - a specification of the binary protocol - some changes to casper-types to expose types needed for the sidecar to work - removal of the existing RPC server The purpose of this PR is to get a high-level review, there are still minor changes being done and unit tests being added. PR for the addition of the sidecar: casper-network/casper-sidecar#231 Co-authored-by: Rafał Chabowski <rafal@casperlabs.io> Co-authored-by: Jacek Malec <145967538+jacek-casper@users.noreply.github.com>
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
casperlabs-bors-ng
bot
merged commit 2f3267a
into
casper-network:feat-2.0
This PR includes:
The purpose of this PR is to get a high-level review, there are still minor changes being done and unit tests being added.
PR for the addition of the sidecar: casper-network/casper-sidecar#231