-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for network soundness test #4613
Merged
bradjohnl
merged 3 commits into
casper-network:feat-2.0
from
rafal-ch:fixes_for_network_soundness_test
Mar 19, 2024
Merged
Fixes for network soundness test #4613
bradjohnl
merged 3 commits into
casper-network:feat-2.0
from
rafal-ch:fixes_for_network_soundness_test
Mar 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alsrdn
approved these changes
Mar 18, 2024
bors r+ |
casperlabs-bors-ng bot
added a commit
that referenced
this pull request
Mar 18, 2024
4602: ee/contract-messages: use `EntityAddr` for messages r=alsrdn a=alsrdn Replace `AddressableEntityHash` with `EntityAddr` in contract messages types. 4603: nctl/nightly-tests: several script fixes for parsing blocks r=alsrdn a=alsrdn Several script changes to support some NCTL functions with feat-2.0. 4610: Fix upgrade test issues in 2.0 r=alsrdn a=jacek-casper Needed to adjust - post-upgrade block parsing - starting up the sidecar in upgrade_from_stage_single_node.sh - counting the nodes while excluding sidecars 4613: Fixes for network soundness test r=rafal-ch a=rafal-ch This PR introduces the changes to `network_soundness.py` test to make it work with Condor. Co-authored-by: Alexandru Sardan <alexandru@casperlabs.io> Co-authored-by: Jacek Malec <145967538+jacek-casper@users.noreply.github.com> Co-authored-by: Rafał Chabowski <rafal@casperlabs.io>
Build failed (retrying...): |
casperlabs-bors-ng bot
added a commit
that referenced
this pull request
Mar 18, 2024
4610: Fix upgrade test issues in 2.0 r=alsrdn a=jacek-casper Needed to adjust - post-upgrade block parsing - starting up the sidecar in upgrade_from_stage_single_node.sh - counting the nodes while excluding sidecars 4613: Fixes for network soundness test r=rafal-ch a=rafal-ch This PR introduces the changes to `network_soundness.py` test to make it work with Condor. Co-authored-by: Jacek Malec <145967538+jacek-casper@users.noreply.github.com> Co-authored-by: Rafał Chabowski <rafal@casperlabs.io>
This PR was included in a batch that successfully built, but then failed to merge into feat-2.0. It will not be retried. Additional information: {"message":"Changes must be made through a pull request.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the changes to
network_soundness.py
test to make it work with Condor.