Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automate handling of binary files #22

Closed
PsiPhiTheta opened this issue Jun 19, 2019 · 3 comments
Closed

automate handling of binary files #22

PsiPhiTheta opened this issue Jun 19, 2019 · 3 comments

Comments

@PsiPhiTheta
Copy link

Unsure as to why this warning comes up, but it seems like it can be safely silenced for a prettier git-fame output:

WARNING:gitfame._gitfame:src/best_params.pickle:'utf-8' codec can't decode byte 0x80 in position 390: invalid start byte

@casperdcl
Copy link
Owner

You should exclude binary files from analysis - for example:

git fame --excl='\.(pickle|pdf|png)$' --cost hour,month

@PsiPhiTheta
Copy link
Author

In that case should these not be excluded by default by git-fame?

@casperdcl
Copy link
Owner

That would mean either

  1. compiling a list of extensions that are likely to correspond to binary data (a very Windows-like non-UNIX approach), or
  2. attempting automatically detect if a file is binary (might not be 100% accurate)

Raising a warning seems safest.

Happy to accept any suggestions though.

@casperdcl casperdcl changed the title Prettify pickle file warnings automate handling of binary files Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants