Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE compatibility #9

Closed
kahlua opened this issue Apr 3, 2013 · 8 comments
Closed

IE compatibility #9

kahlua opened this issue Apr 3, 2013 · 8 comments

Comments

@kahlua
Copy link

kahlua commented Apr 3, 2013

How can I make this plugin IE8 compatible? Thanks in advance.

@casperin
Copy link
Owner

casperin commented Apr 3, 2013

I honestly haven't spend any time trying to make it work in IE and currently have very few ways to test it, so I don't even know how it behaves in IE right now. Honestly I'm not even sure how to debug javascript code in IE.

I'll leave this ticket open as a reminder to get that done soon'ish (kind of busy at the moment with other things unfortunately).

Any help would be appreciated!

@kahlua
Copy link
Author

kahlua commented Apr 3, 2013

Hi Gorm,

Thanks for the response. Turns out, it works great in IE; I overlooked a trailing comma in the metrics.

Great plugin, thank you!

-Mike

From: Gorm Casper [mailto:notifications@github.com]
Sent: Wednesday, April 03, 2013 2:50 PM
To: casperin/nod
Cc: kahlua
Subject: Re: [nod] IE compatibility (#9)

I honestly haven't spend any time trying to make it work in IE and currently have very few ways to test it, so I don't even know how it behaves in IE right now. Honestly I'm not even sure how to debug javascript code in IE.

I'll leave this ticket open as a reminder to get that done soon'ish (kind of busy at the moment with other things unfortunately).

Any help would be appreciated!


Reply to this email directly or view it on GitHub #9 (comment) . https://github.com/notifications/beacon/w5F7Bn8sxh0CDdiYGwbPl-9PJxJeWggEapb5RsRDDKG1heksX0hQKOax7yjIwMvG.gif

@casperin
Copy link
Owner

casperin commented Apr 3, 2013

Oh! Awesome :)

What's the lowest IE you tested it in? Just curious

@casperin casperin closed this as completed Apr 3, 2013
@kahlua
Copy link
Author

kahlua commented Apr 3, 2013

Tested in IE7 and looks good. =)

From: Gorm Casper [mailto:notifications@github.com]
Sent: Wednesday, April 03, 2013 2:56 PM
To: casperin/nod
Cc: kahlua
Subject: Re: [nod] IE compatibility (#9)

Oh! Awesome :)

What's the lowest IE you tested it in? Just curious


Reply to this email directly or view it on GitHub #9 (comment) . https://github.com/notifications/beacon/w5F7Bn8sxh0CDdiYGwbPl-9PJxJeWggEapb5RsRDDKG1heksX0hQKOax7yjIwMvG.gif

@casperin
Copy link
Owner

casperin commented Apr 3, 2013

Sweet. Thanks! Glad you find it useful :-)

@kahlua
Copy link
Author

kahlua commented Apr 4, 2013

Sorry to bother you again but how do I implement nod for a typical ‘yes/no’ radio button group?

Thanks in advance.

-Mike

From: Gorm Casper [mailto:notifications@github.com]
Sent: Wednesday, April 03, 2013 3:17 PM
To: casperin/nod
Cc: kahlua
Subject: Re: [nod] IE compatibility (#9)

Sweet. Thanks! Glad you find it useful :-)


Reply to this email directly or view it on GitHub #9 (comment) . https://github.com/notifications/beacon/w5F7Bn8sxh0CDdiYGwbPl-9PJxJeWggEapb5RsRDDKG1heksX0hQKOax7yjIwMvG.gif

@casperin
Copy link
Owner

casperin commented Apr 4, 2013

You are not bothering. :-)

Right now, you can't I believe. I guess I couldn't think of a usecase for it when I was figuring out what checks to implement. (why not just disable the radio button if you don't want people clicking on it?)

Would it be a good way to implement it same way I did with checkboxes? Where you apply the "presence" to it. That would work, right?

@casperin
Copy link
Owner

casperin commented Apr 5, 2013

I added support for it now, but it was a lot more complex than I expected. I'll update the documentation later, but until then here's a hint:

[ '[name=myRadios]', 'exact:2', 'You must click on second radio' ]

not:2 if you want them not to click on a radio button with value='2'. Hope you figure it out :)

Edit: Please test the hell out of this one and tell me if you find any bugs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants