Complex name fix #32
Merged
Complex name fix #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 16, 2013 11:00
Conflicts: index.html nod.js nod/checker.coffee
Conflicts: nod.js
E.G. user[]first_name
|
I hate how it just auto-closes the ticket. But, thanks! I'm at work right now and will be busy tonight, but I'll test it as soon as I get some free time. Hopefully tomorrow evening. I like the first commit message :P |
|
Excepting the fact I misspelled your name. <.< |
|
Oh I was referring to the "beat me" part of it ;-) The code looks just fine (not really a major change anyhow), so I'm not even sure I'll bother test it myself. It was more to give you a time frame for you to expect to be merged into the master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a minor issue with names. One of the forms we use has complex names (e.g. user[]first_name) for a few radio buttons that was causing the checkers to fail.
(Now referencing the correct branches!)